Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: Mock IO in the Dub class too #2941

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Tests: Mock IO in the Dub class too #2941

wants to merge 11 commits into from

Conversation

Geod24
Copy link
Member

@Geod24 Geod24 commented Jun 22, 2024

This will allow to write more tests for the Dub class. In particular I am interested in being able to write unittests around the config file, which require loadConfig to be callable. We still need to call thisExePath at the moment but that can be solved later as it has no visible side effect.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 22, 2024 •
edited
Loading

✅ PR OK, no changes in deprecations or warnings

Total deprecations: 0

Total warnings: 0

Build statistics:

 statistics (-before, +after)
 executable size=5289208 bin/dub
-rough build time=63s
+rough build time=62s
Full build output 
DUB version 1.37.0, built on May 11 2024
LDC - the LLVM D compiler (1.38.0):
  based on DMD v2.108.1 and LLVM 18.1.5
  built with LDC - the LLVM D compiler (1.38.0)
  Default target: x86_64-unknown-linux-gnu
  Host CPU: znver3
  http://dlang.org - http://wiki.dlang.org/LDC


  Registered Targets:
    aarch64     - AArch64 (little endian)
    aarch64_32  - AArch64 (little endian ILP32)
    aarch64_be  - AArch64 (big endian)
    amdgcn      - AMD GCN GPUs
    arm         - ARM
    arm64       - ARM64 (little endian)
    arm64_32    - ARM64 (little endian ILP32)
    armeb       - ARM (big endian)
    avr         - Atmel AVR Microcontroller
    bpf         - BPF (host endian)
    bpfeb       - BPF (big endian)
    bpfel       - BPF (little endian)
    hexagon     - Hexagon
    lanai       - Lanai
    loongarch32 - 32-bit LoongArch
    loongarch64 - 64-bit LoongArch
    mips        - MIPS (32-bit big endian)
    mips64      - MIPS (64-bit big endian)
    mips64el    - MIPS (64-bit little endian)
    mipsel      - MIPS (32-bit little endian)
    msp430      - MSP430 [experimental]
    nvptx       - NVIDIA PTX 32-bit
    nvptx64     - NVIDIA PTX 64-bit
    ppc32       - PowerPC 32
    ppc32le     - PowerPC 32 LE
    ppc64       - PowerPC 64
    ppc64le     - PowerPC 64 LE
    r600        - AMD GPUs HD2XXX-HD6XXX
    riscv32     - 32-bit RISC-V
    riscv64     - 64-bit RISC-V
    sparc       - Sparc
    sparcel     - Sparc LE
    sparcv9     - Sparc V9
    spirv       - SPIR-V Logical
    spirv32     - SPIR-V 32-bit
    spirv64     - SPIR-V 64-bit
    systemz     - SystemZ
    thumb       - Thumb
    thumbeb     - Thumb (big endian)
    ve          - VE
    wasm32      - WebAssembly 32-bit
    wasm64      - WebAssembly 64-bit
    x86         - 32-bit X86: Pentium-Pro and above
    x86-64      - 64-bit X86: EM64T and AMD64
    xcore       - XCore
   Upgrading project in /home/runner/work/dub/dub/
    Starting Performing "release" build using /opt/hostedtoolcache/dc/ldc2-1.38.0/x64/ldc2-1.38.0-linux-x86_64/bin/ldc2 for x86_64.
    Building dub 1.38.1-rc.1+commit.77.gced95b90: building configuration [application]
     Linking dub
STAT:statistics (-before, +after)
STAT:executable size=5289208 bin/dub
STAT:rough build time=62s

@Geod24 Geod24 force-pushed the mlang/FS branch 4 times, most recently from 04512c4 to 99b5776 Compare June 23, 2024 22:39
@Geod24 Geod24 mentioned this pull request Jun 24, 2024
Merged
@Geod24
Move FSEntry.{writeFile,readText,readFile} to MockFS
cfb973b 
They are better located there than they are in FSEntry,
which is a single node and should not take a NativePath argument.
@Geod24
MockFS: Refactor mkdir to work with absolute path from non-root CWD
3db3724 
mkdir had a bug where it didn't properly support absolute paths,
but expected all paths to be relative to the CWD. This was working
because the tests used the root as the CWD, but as we're attempting
to change that, the bug surfaced.
@Geod24
Filesystem: Give a non-root CWD to tests and implement chdir
f18f66a 
In the real world, it's unlikely Dub is ever started from the root path.
However, in our current unittest framework, that is always the case.
@Geod24
Move removeDir, removeFile, getParent from FSEntry to MockFS
8de019d 
Continue to move logic out of FSEntry so we stop walking the filesystem.
@Geod24
MockFS: Split lookup implementation to correctly handle paths regardl…
52a146d 
…ess of CWD

This should be the last step in separating MockFS from FSEntry.
@Geod24
Tests: Improve root path representation on Windows
74f1350
@Geod24
CI: Move Filesystem instance to Dub class
30542bf 
While we don't use it yet, it allows us to remove the field from out TestDub class
@Geod24
Instantiate PackageManager with Dub's Filesystem instance
94f8243 
This way we can start making use of the Filesystem abstraction in the Dub class.
@Geod24
Remove most dependency to std.file and dub.internal.core.file from Dub
d840503 
By using the Filesystem instance we can start writing better tests,
in this case getting the ability to load configurations from tests.
@Geod24
Trivial: Remove a leftover std.file dependency in PackageManager
0558c21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thewilsonator thewilsonator thewilsonator approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Geod24 @thewilsonator