-
-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Move single checks to Github, remove dead code #2828
Conversation
✅ PR OK, no changes in deprecations or warnings Total deprecations: 0 Total warnings: 0 Build statistics: statistics (-before, +after)
executable size=5343584 bin/dub
rough build time=62s Full build output
|
26b6c9d
to
1e2377b
Compare
Remove support for very old frontend - we were not testing it anyways. Move the useful checks to another job so they run once.
1e2377b
to
defece2
Compare
Just tested that the trailing whitespace check works as it triggered :) |
- name: Run tests | ||
run: | | ||
# check for trailing whitespace | ||
TRAILING_WS_COUNT=$(find . -type f -name '*.d' -exec grep -Hn "[[:blank:]]$" {} \; | wc -l) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be replaced by:
https://github.com/marketplace/actions/editorconfig-action
Remove support for very old frontend - we were not testing it anyways. Move the useful checks to another job so they run once.