Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update version to v1.31.0-beta.1 #2555

Merged
merged 3 commits into from
Jan 3, 2023
Merged

update version to v1.31.0-beta.1 #2555

merged 3 commits into from
Jan 3, 2023

Conversation

ibuclaw
Copy link
Member

@ibuclaw ibuclaw commented Jan 1, 2023

No description provided.

@PetarKirov
Copy link
Member

It looks like the CI is failing on Windows because Dub creates a path that's very long.

@Geod24 do you recall if you encountered such problems when working on the separate build cache feature?

@ibuclaw
Copy link
Member Author

ibuclaw commented Jan 1, 2023

It looks like the CI is failing on Windows because Dub creates a path that's very long.

@Geod24 do you recall if you encountered such problems when working on the separate build cache feature?

First failure that I see was on: 8ad1d43
This change was untested by the CI: 98a355e

It could be there has been a regression in dmd-master, someone with a windows machines can bisect.

@Geod24
Copy link
Member

Geod24 commented Jan 3, 2023

The issue would come from #2542 but the CI was green when I tested.

@ibuclaw
Copy link
Member Author

ibuclaw commented Jan 3, 2023

The issue would come from #2542 but the CI was green when I tested.

I've also seen what looks like the same error in dlang/installer too.

https://github.com/dlang/installer/actions/runs/3825037333/jobs/6507952110

@Geod24
Copy link
Member

Geod24 commented Jan 3, 2023

I've also seen what looks like the same error in dlang/installer too.

That's different. We're doing rm -r of a directly that does not exists (because it is now created elsewhere).
I don't know if the lack of -f is accidental or on purpose (to ensure something was build).

@Geod24
Copy link
Member

Geod24 commented Jan 3, 2023

That job just passed on master, so re-triggering...

@Geod24 Geod24 merged commit 0d42bb7 into dlang:master Jan 3, 2023
@ibuclaw ibuclaw deleted the merge_stable branch January 3, 2023 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants