[minimally improve comments]

dlang · Aug 19, 2023 · ae1362d · ae1362d
1 parent 9f06df5
commit ae1362d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/test/dynLib-monolith/dub.sdl b/test/dynLib-monolith/dub.sdl
@@ -1,5 +1,5 @@
 name "dynlib-monolith"
-description "A 'monolithic' dynamic library, linking all dependencies statically (except for shared druntime/Phobos) and exporting select symbols explicitly via 'export'"
+description "A 'monolithic' dynamic library, linking all dependencies statically (except for shared druntime/Phobos) and exporting only select symbols explicitly via 'export'"
 targetType "dynamicLibrary"
 dependency "inner_dep" path="inner_dep"
 
@@ -9,7 +9,9 @@ dflags "-fvisibility=hidden" platform="gdc"
 # not supported by DMD
 
 # With LDC on Windows, code ending up in a DLL is compiled with
-# `-fvisibility=public -dllimport=all` by default. So we additionally need
-# to override `-dllimport` to use the shared druntime/Phobos DLLs (used by
-# default for dynamic libraries), which is also passed down to all deps:
+# `-fvisibility=public -dllimport=all` by default. So we additionally need to
+# override `-dllimport` to dllimport from the shared druntime/Phobos DLLs only
+# (used by default for dynamic libraries; with static druntime/Phobos via
+# `-link-defaultlib-shared=false`, use `-dllimport=none`).
+# This flag is also passed down to all deps.
 dflags "-dllimport=defaultLibsOnly" platform="windows-ldc"
diff --git a/test/exe-shared-defaultlib/dub.sdl b/test/exe-shared-defaultlib/dub.sdl
@@ -4,7 +4,7 @@ targetType "executable"
 dependency "staticlib-simple" path="../1-staticLib-simple/"
 
 # With LDC on Windows, `-link-defaultlib-shared` is passed down for compiling
-# staticlib-simple (for an implicit `-dllimport=defaultLibsOnly`).
+# all dependencies (for an implicit `-dllimport=defaultLibsOnly`).
 dflags "-link-defaultlib-shared" platform="ldc"
 
 # no libphobos2.dll/dylib with DMD on Windows/Mac