Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduces core.stdc.stdint dependendencies #16649

Closed

Conversation

denizzzka
Copy link
Contributor

@denizzzka denizzzka commented Jul 2, 2024

(Depends from #16647)

This opens up possibility of using core.stdc.stdatomic with -betterC and --mtriple=<arch> (i.e., without libc or OS clarification) for bare-metal compilation

It matters because C atomics also isn't depend from libc implementation

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @denizzzka! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#16649"

@denizzzka denizzzka force-pushed the stdint_wo_unnecessary_modules branch from 8005ce8 to 396afa3 Compare July 2, 2024 22:21
@denizzzka denizzzka marked this pull request as ready for review July 2, 2024 23:07
@denizzzka denizzzka marked this pull request as draft July 4, 2024 12:14
@denizzzka denizzzka force-pushed the stdint_wo_unnecessary_modules branch from f181da3 to 6b04558 Compare July 4, 2024 17:47
@denizzzka denizzzka marked this pull request as ready for review July 4, 2024 17:47
@denizzzka denizzzka marked this pull request as draft July 6, 2024 23:41
@denizzzka denizzzka marked this pull request as ready for review July 7, 2024 00:51
@denizzzka denizzzka marked this pull request as draft July 7, 2024 00:53
@denizzzka denizzzka closed this Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants