Condition → Conditional; IfCondition → Condition

[Bolpat]

Using IfCondition in the grammar is misleading. It can be used for if, but also for while and switch. On the other hand, Condition, which refers to conditional compilation constructs, isn’t the stuff in parentheses of a static if, debug or version, but the whole static if (…) / debug (…) / version (…); therefore, I replaced it with Conditional.

[dlang-bot]

Thanks for your pull request and interest in making D better, @Bolpat! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

• My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
• My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
• I have provided a detailed rationale explaining my changes
• New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

---

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

[dkorpel]

Condition and Conditional are easy to mix up. The dmd codebase calls IfCondition an AssignCondition, I suggest renaming it to that for consistency.

If there's still need to clarify Condition then, perhaps it can become StaticCondition.

[Bolpat]

Condition and Conditional are easy to mix up.

I don’t know how you’d mix those up. A condition is something that you evaluate to a boolean to test it.
An IfCondition should be a condition for an if statement specifically, and is immediately a misnomer if it can be used anywhere where no if is present. IMO, Condition is the perfect name, but I’m not married to Conditional. I chose it because it it wasn’t taken and immediately follows the ConditionalDeclaration and ConditionalStatement. Note that there’s also a ConditionalExpression which is unrelated to conditional compilation. (It should probably named ConditionExpression.)

ConditionalCompilationIntroducer instead for the static if/version/debug thing?

The dmd codebase calls IfCondition an AssignCondition, I suggest renaming it to that for consistency.

I’d really like to keep Condition for what’s in if/while/switch parentheses because it perfectly matches what it means to the average programmer.

Using AssignCondition makes sense for the compiler, I guess, as it spends (probably) much more effort on these:

    auto Identifier = Expression
    scope Identifier = Expression
    TypeCtors Identifier = Expression
    TypeCtors? BasicType Declarator = Expression

If you want AssignCondition in the grammar, that would be my suggestion:

-   IfCondition:
+   Condition:
        Expression
+       AssignCondition
+
+   AssignCondition:
        auto Identifier = Expression
        scope Identifier = Expression
        TypeCtors Identifier = Expression
        TypeCtorsopt BasicType Declarator = Expression

Using AssignCondition for the Expression case is weird.

If there's still need to clarify Condition then, perhaps it can become StaticCondition.

But Condition is simply wrong. It refers not the the boolean expression inside parentheses, but the whole “introducer” to the conditional compilation construct, i.e. the whole static if ( AssignExpression ) version(none) or debug(xyz).

[dkorpel]

ConditionalCompilationIntroducer

That sounds like a Java name 🙂

But Condition is simply wrong.

static if (xyz) debug(xyz) and version(xyz) are all different conditions to compile the following block, the condition isn't merely xyz.

But that's a bit besides the point. I think it's not worth bikeshedding over the best names for grammar production rules. They are mostly local. It's best to just pick something and be consistent with it. This PR changes them for marginally better clarity at best, so unless the names are made consistent with dmd (which is a nice property as they often need to be compared), I'd err on the side of keeping them as is.