Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dsymbol to latest stable tag #655

Closed
wants to merge 1 commit into from

Conversation

nordlow
Copy link
Contributor

@nordlow nordlow commented Oct 9, 2021

dub test pass locally.

@WebFreak001
Copy link
Member

update dub.json?

@nordlow
Copy link
Contributor Author

nordlow commented Oct 10, 2021

update dub.json?

Done, @WebFreak001. Ready to merge.

@nordlow
Copy link
Contributor Author

nordlow commented Oct 10, 2021

update dub.json?

Done, @WebFreak001. Ready to merge.

Is it possible to use a commit sha for current master HEAD instead of master as a dub dependency tag?

@WebFreak001
Copy link
Member

~master doesn't actually mean latest commit on dub, unless you always run dub upgrade before building

It's better to rely on tags because of caching as well as traceability with releases.

@RazvanN7
Copy link

@WebDrake could you maybe push a new tag of dsymbol?

@WebDrake
Copy link

@RazvanN7 I take it you meant @WebFreak001 there ... ? :-)

@RazvanN7
Copy link

@WebDrake Sorry for the spam :(

@WebFreak001
Copy link
Member

@RazvanN7 created a new tag + release

Just found out Github can auto generate changelogs now which is pretty neat!

@nordlow
Copy link
Contributor Author

nordlow commented Oct 19, 2021

@RazvanN7 created a new tag + release

Just found out Github can auto generate changelogs now which is pretty neat!

I don't see any fresh tags at https://github.com/dlang-community/dsymbol/tags.

@nordlow
Copy link
Contributor Author

nordlow commented Oct 19, 2021

@RazvanN7 created a new tag + release
Just found out Github can auto generate changelogs now which is pretty neat!

I don't see any fresh tags at https://github.com/dlang-community/dsymbol/tags.

Ok, now I see https://github.com/dlang-community/dsymbol/releases/tag/v0.12.0. I can't see the tag having propagated to DUB registry at https://code.dlang.org/packages/dsymbol, though.

@WebFreak001
Copy link
Member

WebFreak001 commented Oct 19, 2021

I don't own the registry item, will take a while until it's updated.

Until then, you could maybe look into dlang/dub-registry#414 which implements automatic updates via webhook which you can setup in github :p

@nordlow
Copy link
Contributor Author

nordlow commented Oct 19, 2021

I don't own the registry item, will take a while until it's updated.

Until then, you could maybe look into dlang/dub-registry#414 which implements automatic updates via webhook which you can setup in github :p

Got it! ;)

@nordlow nordlow closed this Oct 19, 2021
@nordlow nordlow deleted the bump-dsymbol branch October 19, 2021 19:46
@nordlow nordlow restored the bump-dsymbol branch October 19, 2021 19:51
@nordlow nordlow reopened this Oct 19, 2021
@nordlow nordlow changed the title Bump dsymbol to master Bump dsymbol to latest stable tag Oct 20, 2021
@nordlow
Copy link
Contributor Author

nordlow commented Oct 20, 2021

Can someone please trigger the dub registry bump to 0.12 at https://code.dlang.org/packages/dsymbol?

@WebFreak001
Copy link
Member

@Hackerpilot can you trigger a refresh on the dub registry package?

@WebFreak001
Copy link
Member

this PR has become obsolete (dsymbol was updated with #673)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants