use NewLine's in looped WrappedHStacks #52
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just started using this components and ran into this issue. @dkk , any interest in merging this and creating a new release? I might create a fork otherwise. Thanks for this btw! |
|
I appreciate the effort put into this PR, but I believe there might be a more elegant solution. I would prefer not to merge it at this time. Thank you for your understanding. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change to address issue #38 - addresses the situation in
ViewType init(rawView:)whererawViewis wrapped as a_ConditionalContenttype (because of the presence of multiple conditional types in a loop's content builder) which causes it to fail theis NewLineswitch case.