Skip to content

Commit

Permalink
ci: replace --all in cargo clippy/test with --workspace
Browse files Browse the repository at this point in the history
The `--all` flag in `cargo check/clippy/test` has been deprecated in
favor of `--workspace`: rust-lang/cargo#7241.

`--all` in `cargo fmt` is retained because it has a little different
meaning. From rust-lang/rustfmt#3911:

> For example, when running `cargo fmt` in the root directory of a
> workspace, `cargo fmt` already formats all of the workspace members.
> Running `cargo fmt --all` formats the workspace *plus* any local/path
> based dependencies of the packages in that workspace, regardless of
> whether those local deps are explicit workspace members.
  • Loading branch information
dkim committed Jan 12, 2020
1 parent 94b603c commit ffc3491
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
uses: actions-rs/cargo@v1
with:
command: test
args: --verbose --all --all-targets --all-features -- -Z unstable-options --include-ignored
args: --verbose --workspace --all-targets --all-features -- -Z unstable-options --include-ignored

cargo-test-macos:
name: cargo test (macOS)
Expand All @@ -52,7 +52,7 @@ jobs:
uses: actions-rs/cargo@v1
with:
command: test
args: --verbose --all --all-targets --all-features -- -Z unstable-options --include-ignored
args: --verbose --workspace --all-targets --all-features -- -Z unstable-options --include-ignored

cargo-test-windows:
name: cargo test (Windows)
Expand All @@ -71,7 +71,7 @@ jobs:
run: |
set "LIB=%LIB%;%VCPKG_INSTALLATION_ROOT%\installed\x64-windows\lib"
set "PATH=%PATH%;%VCPKG_INSTALLATION_ROOT%\installed\x64-windows\bin"
cargo test --verbose --all --all-targets --all-features -- -Z unstable-options --include-ignored
cargo test --verbose --workspace --all-targets --all-features -- -Z unstable-options --include-ignored
shell: cmd

cargo-fmt-clippy:
Expand All @@ -95,4 +95,4 @@ jobs:
uses: actions-rs/cargo@v1
with:
command: clippy
args: --verbose --all --all-targets --all-features -- --warn rust_2018_idioms --deny warnings
args: --verbose --workspace --all-targets --all-features -- --warn rust_2018_idioms --deny warnings

0 comments on commit ffc3491

Please sign in to comment.