Correct behaviour of CheckBoxController with values #59
Conversation
| @@ -132,7 +140,7 @@ public void refresh(CheckBox checkbox, int index) { | |||
| Set<Object> modelValues = retrieveModelValues(); | |||
| checkbox.setChecked( | |||
| modelValues.contains( | |||
| areValuesDefined() ? checkbox.getText() : index | |||
| !areValuesDefined() ? checkbox.getText() : values[index] | |||
There was a problem hiding this comment.
What's the exact issue you're trying to solve? The current behavior is already the same as SelectionController as far as I can tell.
The current implementation is based on the documented behavior (see comments in the constructor). Specifically, if the useItemsAsValues param that is passed in to the constructor is false, the CheckBoxController will represent the selected fields using the 0-based index (as in integer). When you want to read the values in your UI, you can perform the index-to-value mapping if needed.
Let me know if I'm missing something.
There was a problem hiding this comment.
Okay, basically the problem is that my values are not my text of the checkbox, since sometimes I might have a checkbox with value a and translated title of a. I see your point that the 0-based index muss be supported, so I updated the PR
|
Update PR, is it now ok? :) |
|
Note that I've released version 0.4.2 that includes your fix. |
When passing a array of values, CheckboxController was having wrong. Now it's doing like SelectionController