Skip to content

include defaults in create function signature #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joshainglis
Copy link

I noticed when altering the default value of a function parameter that migra didn't pick up that there had been a change.
This was due to only using pg_get_function_identity_arguments() for the signature, which does not include defaults.

This change adds an extra column to the functions.sql query to get pg_get_function_arguments(p.oid) as function_arguments which is then used as the signature for the create function statement. We still use the identity arguments for dropping the function.

@djrobstep djrobstep force-pushed the master branch 3 times, most recently from 13f62b5 to ebbc2e4 Compare September 18, 2022 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant