Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create newrelic user to fix java and ruby agent installation #334

Closed
wants to merge 3 commits into from

Conversation

acondrat
Copy link
Contributor

As described in #313, java and ruby agent installation fails because newrelic user does not exist. The user is created when you include newrelic::server_monitor_agent recipe but:
a. you do not want to have server monitor agent installed in some cases
b. it is being deprecated in favor of New Relic Infrastructure. The later does not create a separate user and runs as root.

To solve this, I attempt to create the user unless it already exist.

@acondrat
Copy link
Contributor Author

Any chance to get this reviewed?

@djoos
Copy link
Member

djoos commented Apr 24, 2018

Hi @Condrat,

I'd rather have a check in place that fails if the specified user does not exist. It feels like bloat to add in the user creation in the New Relic cookbook as well...

It's open for discussion though - if the direction is preferred to create the user, then at least the relevant attributes will need to be added on the LWRP, rather than relying on node attributes.

Thanks in advance!
David

@acondrat acondrat closed this May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants