This repository has been archived by the owner on Mar 27, 2019. It is now read-only.
Fixes string parsing bug and warnings in run-docker-compose-dev #242
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my system, I ran into a breaking issue with
run-docker-compose-dev
, where the root token would be fetched from the Docker log with some color control characters at the end ([0m
):Resulting in the following error (when running
vault auth $token
):This PR fixes this issue by stripping control characters from the token. Also several commands have been updated to avoid deprecation warnings. The command now runs without any warnings or errors: https://gist.github.com/mtak/029a0b8ac4a1568d237bda4d8261d53c
System info (Ubuntu 17.10):