Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust mendes version to 0.5.1 #91

Closed
wants to merge 1 commit into from
Closed

Adjust mendes version to 0.5.1 #91

wants to merge 1 commit into from

Conversation

djc
Copy link
Owner

@djc djc commented Dec 13, 2023

The changes in #89 were actually semver-compatible, since they merely widen the blanket impl of IntoResponse for Result.

r? @valkum

The changes in #89 were actually semver-compatible, since they merely
widen the blanket impl of IntoResponse for Result.
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (de0f01f) 57.47% compared to head (3e6f61c) 57.47%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #91   +/-   ##
=======================================
  Coverage   57.47%   57.47%           
=======================================
  Files           7        7           
  Lines        1364     1364           
=======================================
  Hits          784      784           
  Misses        580      580           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@valkum valkum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure? Reading rust-lang/cargo#8736 and https://github.com/rust-lang/rfcs/blob/master/text/2451-re-rebalancing-coherence.md#effects-on-parent-crates. I don't want to spend time trying to find an example that breaks. Feel free to merge if you think RFC2451 does not apply here.

@djc djc closed this Dec 14, 2023
@djc djc deleted the version-tweak branch June 27, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants