Application service

[djc]

@valkum this is more like what I had in mind -- this seems like the simplest formulation that makes it easy to use an Application to build a hyper Server. What do you think?

Alternative to #82.

[codecov]

Codecov Report

Patch coverage is 100.00% of modified lines.

Files Changed	Coverage
mendes/src/application.rs	100.00%
mendes/src/hyper.rs	100.00%

📢 Thoughts on this report? Let us know!.

[valkum]

I assume you can't call Into::into because Rust can't infer the type to convert into?
What's the benefit of

hyperServer::bind()
  .serve(ApplicationService::from(App::default()))
  .await

vs

hyperServer::bind()
  .serve(App::default().into_hyper_service())
  .await

We won't need to make ApplicationService completely pub (pub in private module should be enough), keeping the API interface cleaner.

[djc]

I assume you can't call Into::into because Rust can't infer the type to convert into? What's the benefit of

hyperServer::bind()
  .serve(ApplicationService::from(App::default()))
  .await

vs

hyperServer::bind()
  .serve(App::default().into_hyper_service())
  .await

Changed it to add a provided method on Application.

We won't need to make ApplicationService completely pub (pub in private module should be enough), keeping the API interface cleaner.

IMO that's a minimal difference and as a user I have found types that are pub in private module very frustrating (a type in the docs that you can't click to get more info). I'd rather expose the public type, which is pretty opaque anyway.

[valkum]

Looks good.