Implement RFC 8555 §6.7.1 subproblems #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpu
commented
Feb 21, 2025
cpu
commented
Feb 21, 2025
cpu
commented
Feb 21, 2025
djc
approved these changes
Feb 22, 2025
This will allow using an `Identifier` in subproblem error descriptions.
djc
reviewed
Feb 22, 2025
djc
approved these changes
Feb 22, 2025
Trying to issue for an order that contains a forbidden identifier should produce a top-level problem with one sub-problem that identifiers the specific identifier at fault.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an ACME CA rejects an order submitted by a client it's helpful to be able to indicate which of the order's identifiers are at fault and why. RFC 8555 §6.7.1 describes how subproblems within a top-level problem are used for this purpose.
This branch implements support for capturing and rendering problem information containing subproblems based on §6.7.1. Pebble implemented returning subproblems for the case where an identifier in an order is rejected on the basis of CA policy (letsencrypt/pebble#383). We use this implementation to add a new integration test exercising a problem-with-subproblems response from the test CA.