poll certificate function #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
reviewed
Jul 2, 2025
cpu
reviewed
Jul 2, 2025
christianhoelzl
force-pushed
the
poll_certificate
branch
from
b078e0d to
1af0f25
Compare
christianhoelzl
force-pushed
the
poll_certificate
branch
from
1af0f25 to
4a9fc6f
Compare
djc
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a new function to poll a certificate. In contrast to the existing
Order::certificatefunction, this method retries in case of aProcessingstate based on the retry policy.Pebble testing is modified such that it uses the new method
Order::poll_certificate. This removes aloopfrom the test functionEnvironment::certificate.I can add commits to this pr if wanted:
Order::polltoOrder::poll_readyOrder::certificate