Skip to content

Conversation

ulgens
Copy link
Member

@ulgens ulgens commented Oct 11, 2025

Supersedes:

I tested different versions and commits from the django-hosts repo and found that jazzband/django-hosts@591bf5d creates a behavioral change that results in some responses we test to switch from FOUND to OK. I'm not exactly sure why and I could some help to understand that.

@ulgens ulgens self-assigned this Oct 11, 2025
@ulgens ulgens added the dependencies Pull requests that update a dependency file label Oct 11, 2025
@ulgens ulgens requested a review from a team October 11, 2025 22:11
@ulgens ulgens marked this pull request as ready for review October 11, 2025 22:21
@ulgens ulgens requested a review from a team October 12, 2025 09:35
@SaptakS SaptakS merged commit 3640cc5 into django:main Oct 13, 2025
5 checks passed
@bmispelon
Copy link
Member

I'm not exactly sure why and I could some help to understand that.

I don't understand why this PR was merged if nobody has been able to provide an explanation as to the behavior change. Did I miss a discussion somewhere?

@SaptakS
Copy link
Contributor

SaptakS commented Oct 13, 2025

Apologies, I overlooked that this PR was looking for further clarification. I reviewed, and status OK made sense to me (since I don't think those URLs are supposed to be redirected), and I saw the commit linked by @ulgens and it seems to add support for considering PARENT_HOST which was not supported before, which is what I assume caused the change in status code.

@bmispelon I am happy to revert the PR, if you think that makes more sense. Apologies on my part for missing that this PR was waiting on more discussion.

@ulgens ulgens deleted the bump-django-hosts branch October 14, 2025 19:05
@ulgens
Copy link
Member Author

ulgens commented Oct 16, 2025

I believe we won't need to revert the PR - it doesn't look like it's breaking or dangerous in any way, but I'd like to know more about what's causing the change on our end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants