Skip to content

Changed GH action to publish images from the preview branch too #2153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 13, 2025
Merged

Changed GH action to publish images from the preview branch too #2153

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dabaaf7
Changed GH action to publish images from the preview branch too
bmispelon Aug 7, 2025
3cb2aa2
Hardcoded default branch name
bmispelon Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/docker-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Create and publish a Docker image

on:
push:
branches: ["main"]
branches: ["main", "preview"]

env:
REGISTRY: ghcr.io
Expand Down Expand Up @@ -31,9 +31,9 @@ jobs:
uses: docker/metadata-action@v5
with:
images: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}
flavor: |
latest=true
tags: |
# set latest tag for main branch only
type=raw,value=latest,enable={{is_default_branch}}
Copy link
Member

@ulgens ulgens Aug 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to make this dynamic? I believe having a hardcoded "main" is safe enough.

Copy link
Member Author

@bmispelon bmispelon Aug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got the {{is_default_branch}} from the action's documentation: https://github.com/docker/metadata-action?tab=readme-ov-file#latest-tag. I do agree that having a hardcoded main is unlikely to cause issues so I'm happy to change that.

type=ref,event=branch
type=sha

Expand Down