Skip to content

Conversation

@devkral
Copy link
Contributor

@devkral devkral commented Jun 11, 2025

Changes:

  • fix django 5.2 compatibility
  • add tests for ChannelsLiveServerTestCase
  • add test project and use its settings
  • fix hangup when the server failed to start

Changes:

- fix django 5.2 compatibility
- add tests for ChannelsLiveServerTestCase
- add test project and use its settings
- fix hangup when the server failed to start
@devkral devkral force-pushed the bugfixes/django52 branch from ef54e10 to 751ad89 Compare June 11, 2025 11:11
@carltongibson
Copy link
Member

@devkral This is a duplicate of #2160. Could you provide a review there please?

@devkral
Copy link
Contributor Author

devkral commented Jun 11, 2025

sry, yes. I was asked a couple of weeks ago but had no time. Didn't checked the state properly.

But I fix some other issues too. We may should use my fix for the ChannelsLiveTestCase and his tests+sample project

@carltongibson
Copy link
Member

Thanks for this @devkral. I'm going to close in favour of #2160.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants