Basket needs to be frozen while customer is at PayPal's site #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This involves some trickyness with the templates as the default preview.html wants to render the open basket (which is injected into the template context via the basket middleware). We duplicate some of the basket template so we can render an alternative basket (the frozen one).
| _("No basket was found that corresponds to your " | ||
| "PayPal transaction")) | ||
|
|
||
| return self.submit(basket, order_kwargs=order_kwargs) |
There was a problem hiding this comment.
Basket is not available if the get fails, is it?
There was a problem hiding this comment.
Well spotted.
|
Now merged into master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, the library is vulnerable to basket manipulation while the customer is on the PayPal site, submitting payment information.