Skip to content

Conversation

@knaperek
Copy link
Contributor

@knaperek knaperek commented Jun 18, 2021

Description of the Change

This is needed to avoid 2 extra DB queries per each line in the list view, so that is usually +200 unnecessary queries.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@codecov
Copy link

codecov bot commented Jun 18, 2021

Codecov Report

Merging #988 (49951a0) into master (6dbde71) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #988   +/-   ##
=======================================
  Coverage   96.55%   96.56%           
=======================================
  Files          31       31           
  Lines        1715     1716    +1     
=======================================
+ Hits         1656     1657    +1     
  Misses         59       59           
Impacted Files Coverage Δ
oauth2_provider/admin.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dbde71...49951a0. Read the comment docs.

This is needed to avoid 2 extra DB queries per each line in the list view, so that is usually +200 unnecessary queries.
@auvipy
Copy link
Contributor

auvipy commented Sep 2, 2021

CHANGELOG.md updated (only for user relevant changes) is not updated

@knaperek
Copy link
Contributor Author

knaperek commented Sep 2, 2021

CHANGELOG is not updated as this is not a user relevant change. I marked that tickbox as having that step completed, that is, updated CHANGELOG in case of a user relevant change; which it wasn't, so this is a no-op :-)

@auvipy
Copy link
Contributor

auvipy commented Sep 2, 2021

ok

@auvipy auvipy merged commit 6625d3a into django-oauth:master Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants