Add post_logout_redirect_uris field to application views#1285
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1285 +/- ##
==========================================
+ Coverage 97.25% 97.30% +0.04%
==========================================
Files 32 32
Lines 2005 2005
==========================================
+ Hits 1950 1951 +1
+ Misses 55 54 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
n2ygk
requested changes
Jun 12, 2023
Contributor
n2ygk
left a comment
There was a problem hiding this comment.
This looks like new functionality that needs to be documented. Please update the docs. See docs related to redirect_uris
Looks like you may want to also update the create_application management command.
Contributor
Author
|
The management command already allows to specify post_logout_redirect_uris : see here I've added the new fields in the documentation |
n2ygk
approved these changes
Jun 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
These are missing since RP-initiated logout was added.
I added more tests on the applications views
Checklist
CHANGELOG.mdupdated (only for user relevant changes)AUTHORS