Improve Error class#1882
Merged
matthewhegarty merged 3 commits intodjango-import-export:mainfrom Jun 19, 2024
Merged
Conversation
1. Lazily compute the traceback string, using `traceback.format_exception()`. It’s only used in the rare case that `"traceback"` is in the `import_error_display` attribute. 2. Add a nice `__repr__`, to help debug test failures that make assertions on `Error` objects. I had a few cases where tests failed with inscrutable messages from pytest like `Left contains one more item: <import_export.results.Error object at 0x3173c8690>`, and I needed to rerun the test with the debugger to inspect the inner exception.
adamchainz
force-pushed
the
improve_error_class
branch
from
15b49b2 to
c4716a8
Compare
Removed extraneous bracket
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
traceback.format_exception(). It’s only used in the rare case that"traceback"is in theimport_error_displayattribute, so we can save that work and memory in the usual case.__repr__, to help debug test failures that make assertions onErrorobjects. I had a few cases where tests failed with inscrutable messages from pytest likeLeft contains one more item: <import_export.results.Error object at 0x3173c8690>, and I needed to rerun the test with the debugger to inspect the inner exception.