Implement selectable fields for admin export view - #1538#1734
Merged
matthewhegarty merged 20 commits intodjango-import-export:release-4from Jan 11, 2024
Merged
Conversation
cocorocho
changed the title
cocorocho
changed the title
matthewhegarty
requested changes
Jan 9, 2024
Contributor
matthewhegarty
left a comment
matthewhegarty
left a comment
There was a problem hiding this comment.
Looks really good, thanks so much for adding this.
I have gone through it and I only have some minor points.
import_export/templates/admin/import_export/selectable_resource_export_fields.html
Outdated
Show resolved
Hide resolved
Contributor
|
@cocorocho would you be ok with me adding some documentation updates to this PR? |
Contributor
|
I added some documentation updates. |
…ho/django-import-export into selectable-export-fields
Contributor
matthewhegarty
left a comment
matthewhegarty
left a comment
There was a problem hiding this comment.
Looks good. One comment re semicolons in JS.
matthewhegarty
approved these changes
Jan 11, 2024
Contributor
matthewhegarty
left a comment
matthewhegarty
left a comment
There was a problem hiding this comment.
Thank you for all your hard work in adding this amazing feature 👍
Contributor
Author
Glad to help 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #1538
Problem
What problem have you solved?
Implement new feature selectable export fields for admin view.
Solution
How did you solve the problem?
Create new form
SelectableFieldsExportFormwhich creates boolean fields for each resource.Acceptance Criteria
Have you written tests? Have you included screenshots of your changes if applicable?
Yes
Did you document your changes?
To some extend,
Official documentation is not quite up to date.
Export View
Export Result
Any field selected validation
