ForeignKeyWidget: add get_lookup_kwargs()#1651
Merged
matthewhegarty merged 2 commits intodjango-import-export:release-4from Oct 11, 2023
Merged
Conversation
rpsands
approved these changes
Oct 11, 2023
rpsands
left a comment
rpsands
left a comment
There was a problem hiding this comment.
Nice! This granularity is useful all over in terms of improving the customizability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Closes #1516
In order to override ForeignKey lookup you have to override the
clean()method.Solution
Add an overrideable method
get_lookup_kwargs()Also fixes a bug in the test app where the author's birthday could never be set.
Acceptance Criteria
Test added.