use gthread instead of gevent to allow multithreading #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are currently using
gevent
as a worker-class for Gunicorn which can handle high volume of concurrent HTTP requests. However, it's impossible to use multi-threading in the daiquiri-apps ( for example thethreading
library).The alternative is to use the
gthread
worker which can handle not only the concurrent HTTP request but also the OS-level threads. AFAIK, the downside for usinggthread
is potentially a higher resource consumption by high number of simultaneous connections . For some apps that use multi-threading,gthread
is required to work at all.IMHO, there are two possible solutions:
gevent
togthread
. I'm not sure what would be the appropriate number of workers and threads in this case. atm, this is my preferred solution.dq-dev
usesgthread
instead ofgevent
for Gunicorn. This solution is more flexible but adds another variable to the config which is already somewhat overcrowded.