-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for accordion-flush and accordion always open #63
Conversation
Well, tests passed. Let me know what you think of the new tests and the way I used the classes at bootstrap5.py. Those are the points I'm most unsure about. Cheers! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, thank you. 👍
Although I've not yet sat down with this properly I've left a few initial comments.
Thanks again. :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates. Would you like to add a small note to the readme to document the new feature in this template pack? Happy to help, just let me know.
Of course! I'll follow the floating labels note style |
Thanks for all your efforts here 🥇 |
This addresses #60, #61 and #62. Tests should work now.
The term "always open" sounds misleading to me, but it's what the folks at Bootstrap use. We could change this to something more descriptive if judged necessary.
I'm not sure about the way I pulled classes from bootstrap.py. It feels awkward. I was inheriting from the original classes before and adding just what I needed, but it somehow felt worse. Any suggestions?