Skip to content

Conversation

@p-r-a-v-i-n
Copy link
Member

since we are using pyproject.toml depending on extra file for dependency is redundant. we should use the power of pyproject.toml to take care of it.

according PEP 735 we can use dependency groups which is more convenient.

@p-r-a-v-i-n p-r-a-v-i-n marked this pull request as draft December 11, 2025 08:29
@github-actions
Copy link

github-actions bot commented Dec 11, 2025

Coverage report

This PR does not seem to contain any modification to coverable code.

@p-r-a-v-i-n p-r-a-v-i-n marked this pull request as ready for review December 11, 2025 08:51
@p-r-a-v-i-n p-r-a-v-i-n force-pushed the rm-requirements branch 2 times, most recently from f5cec10 to b3bab6b Compare December 15, 2025 12:55
Comment on lines 11 to 12
commands:
- pip install --group docs
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think now this should work

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adjusting things. Did you happen to test this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I haven't test this. bcs i have no idea to test this locally.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to change this based on this part of the docs: https://docs.readthedocs.com/platform/stable/config-file/v2.html#build-commands

Copy link
Member

@tim-schilling tim-schilling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for iterating on this. I still have some open questions unfortunately. I'm sorry for the slow responses.

@p-r-a-v-i-n
Copy link
Member Author

Hey @tim-schilling ,
I like working with you. I like your insights. and your feedback really helps me understand things even more better.

Currently I have some thoughts in my mind.

  1. I have strong believe that for building docs it will pick pip install --group docs, but it just assumption no strong evidence ( bcs no experience).
  2. I'm not sure whether this changes are absolutely requires at this movement. Honestly, I submitted this PR for my personal milestone , and I understood personal milestone should not be greater than the project need. Project requirement should be the first priority.

I'm happy to iterate as per the feedback. and I'm happy answer/discuss questions. Thank you.

Copy link
Member

@tim-schilling tim-schilling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a different workflow than I'm used to, though I think it's close to a mergeable state. @matthiask or I will need to check on the readthedocs integration after this gets merged. It's probably a good idea regardless since it's been a while since I've looked at that.

I'd like to get opinions from @django-commons/django-debug-toolbar on whether this is +1, 0 or -1 type thing. For me, I'm very used to pip install -r requirements_dev.txt. I suspect I will get tripped up by this change for a while. That said, I'm a 0 on it. I like the docs dependency group for read the docs.

@matthiask
Copy link
Member

I think dependency groups is the way to go (except if everybody starts using something like uv projects).

I worry slightly that e.g. the system pip on Ubuntu 22.04 (22.0.2, shipping with Python 3.10) doesn't support dependency groups yet. When using virtualenvs the first thing I do is update pip anyway so it's not a big concern, but I wonder.

That said, people are probably (and should be) using newer versions of the OS and Python in their development environments for current projects. We don't support outdated versions of Python and Django, and Django also does not. So we're probably fine moving ahead with this.

Re. readthedocs, I really can't say. I've mostly been using old techniques as well when I had to install requirements. We will see what happens.

@tim-schilling
Copy link
Member

Rebased on main. Will squash these commits down, then wrangle with ReadTheDocs.

@tim-schilling tim-schilling merged commit 3c4870d into django-commons:main Feb 8, 2026
28 checks passed
@tim-schilling
Copy link
Member

Thank you @p-r-a-v-i-n!

@p-r-a-v-i-n p-r-a-v-i-n deleted the rm-requirements branch February 8, 2026 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants