Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add support of django 4.0 #203

Merged
merged 2 commits into from
Aug 19, 2022

Conversation

jbpenrath
Copy link
Contributor

@jbpenrath jbpenrath commented Aug 5, 2022

Description

django-cms 3.11 adds the support of django 4.0 but currently djangocms-link is not compatible with this version of django as there is use of force_text in the codebase. So we remove the use of this deprecated method in favor of force_str.

Related resources

Checklist

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

@jbpenrath jbpenrath changed the title ⬆️(deps) Add support of django 4.0 fix: add support of django 4.0 Aug 5, 2022
@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

Merging #203 (6b40481) into master (3afb7e4) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #203   +/-   ##
=======================================
  Coverage   93.54%   93.54%           
=======================================
  Files          22       22           
  Lines         279      279           
  Branches       53       53           
=======================================
  Hits          261      261           
  Misses         11       11           
  Partials        7        7           
Impacted Files Coverage Δ
djangocms_link/models.py 94.73% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@vinitkumar
Copy link
Member

Thanks for your pull request @jbpenrath. I see a couple of things missing from your PR. It would be wonderful if you can add those too.

These needs to be updated: https://github.com/django-cms/djangocms-link/blob/master/.github/workflows/test.yml#L17

Please add a requirements file for django4.0 as well and add their reference in the test.yml so that the CI also tests it against those version.

django-cms 3.11 adds the support of django 4.0 but currently
djangocms-link is not compatible with this version of django as there is
use of force_text in the codebase. So we remove the use of this
deprecated method in favor of `force_str`.

Resolve django-cms#202
tests/requirements/dj40_cms311.txt Outdated Show resolved Hide resolved
@jbpenrath jbpenrath requested a review from marksweb August 5, 2022 14:53
@FinalAngel FinalAngel merged commit faf439b into django-cms:master Aug 19, 2022
@jbpenrath jbpenrath deleted the fix/support-django-4 branch September 5, 2022 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants