Display page title instead of menu title #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marksweb
approved these changes
Aug 3, 2021
marksweb
requested changes
Feb 23, 2022
There was a problem hiding this comment.
@adrien-delhorme could you please add an entry in the changelog under an "Unreleased" title for this?
Codecov Report
@@ Coverage Diff @@
## master #194 +/- ##
=========================================
Coverage ? 93.54%
=========================================
Files ? 22
Lines ? 279
Branches ? 53
=========================================
Hits ? 261
Misses ? 11
Partials ? 7
Continue to review full report at Codecov.
|
|
Sure! (done) |
|
@adrien-delhorme fantastic, thank you! |
marksweb
approved these changes
Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default label for select2 items are the Page's
__str__method, which displays the page's menu title.It happens frequently that several pages share the same menu title: they are therefore indistinguishable from each other.
This pull request displays the page's title instead of the menu title.