fix: django import error

[src-r-r]

Description

Just a simple PR to fix the import error. Line 5-9 are the "real" changes.

All the other changes you see are just the linter cleaning up the code.

Related resources

• ungettext import error #161

Checklist

• I have opened this pull request against master
• I have added or modified the tests when changing logic
• I have followed the conventional commits guidelines to add meaningful information into the changelog
• I have read the contribution guidelines and I have joined #workgroup-pr-review on
  Slack to find a “pr review buddy” who is going to review my pull request.

[codecov]

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (1726033) 98.94% compared to head (f78a1e3) 98.94%.

❗ Current head f78a1e3 differs from pull request most recent head ff85640. Consider uploading reports for the commit ff85640 to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #162   +/-   ##
=======================================
  Coverage   98.94%   98.94%           
=======================================
  Files          71       71           
  Lines        1228     1228           
  Branches       70       70           
=======================================
  Hits         1215     1215           
  Misses          8        8           
  Partials        5        5           

Files Changed	Coverage Δ
...gocms_bootstrap4/contrib/bootstrap4_grid/models.py	100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[fsbraun]

@src-r-r Thank you for the PR.
Can I suggest replacing ungettext by ngettext everywhere as opposed to importing as? The unicode functions are gone for good.

[src-r-r]

Yikes, sorry about that, been stressing out about finding sustainable work so haven't gotten to it. It's super-quiet today so I'll work on it (BTW, if you happen to know of anyone who needs a team lead, feel free to reach out).

[fsbraun]

Thank you for the update!

I guess the ngettext as ngettext is probably unnecessary.

Also, you'll have to remove mptt from the test settings, since mptt is gone from django-filer. (See here:

djangocms-bootstrap4/tests/settings.py

Line 7 in 2c095d3

'mptt',

)

[brenosss]

HI, it looks like this change is required to use Django 4.2. Is there a plan to release those changes?