-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support djangocms-static-ace to load ace code editor from static files #156
Conversation
… files instead of cdn Fix: Move to version ace v1.9.6
Codecov Report
@@ Coverage Diff @@
## master #156 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 71 71
Lines 1211 1214 +3
Branches 155 156 +1
=========================================
+ Hits 1211 1214 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@fsbraun based on the failing test, this may also need an |
@marksweb The new migrations seem to be happening for cms 3.9. Not sure, |
I now skip the migration test for django cms 3.9. This will probably be an issue for other apps, too. |
@fsbraun I'll take a look shortly |
Description
This PR allows the code editor ace to be served from static files with the help of djangocms-static-ace.
En passant add color scheme detection for the ace editor (dark mode).
Related resources
Checklist
master
Slack to find a “pr review buddy” who is going to review my pull request.