Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Add missing copy import #141

Merged
merged 2 commits into from
Nov 2, 2021

Conversation

crydotsnake
Copy link
Contributor

Related to this pull request: #138

Because of failing checks, i try to fix the issue:
https://github.com/django-cms/djangocms-bootstrap4/runs/4082975004?check_suite_focus=true

@crydotsnake crydotsnake self-assigned this Nov 2, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2021

Codecov Report

Merging #141 (1e5527b) into master (cef6a92) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #141   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           71        71           
  Lines         1210      1211    +1     
  Branches        65        65           
=========================================
+ Hits          1210      1211    +1     
Impacted Files Coverage Δ
..._bootstrap4/contrib/bootstrap4_link/cms_plugins.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 713c1c8...1e5527b. Read the comment docs.

@marksweb
Copy link
Sponsor Member

marksweb commented Nov 2, 2021

@crydotsnake what happened on #138, did the checks not pass or did they not run?

I was using the github app on my phone so checks/actions aren't available.

@marksweb marksweb merged commit b01151e into django-cms:master Nov 2, 2021
@crydotsnake
Copy link
Contributor Author

The checks failed because import copy was missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants