Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove extra brace in generated HTML of data-max-filesize attribute #1502

Merged

Conversation

fabien-michel
Copy link
Contributor

Description

Template insert an extra brace before data-max-filesize attribute making it not read as expected by table-dropzone.js

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

@fsbraun
Copy link
Sponsor Member

fsbraun commented Oct 16, 2024

@fabien-michel Thanks for fixing this! What a bummer!

@fsbraun fsbraun merged commit efa9892 into django-cms:master Oct 16, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants