fix: issues with filer image crash when trying to generate thumbnail #1384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thumbnail generation can fail when the image is not present or moved or if we have a reference in database but no image in storage. - Github Issue: Fixes #1379 Authored-by: Vinit Kumar <[email protected]> Signed-off-by: Vinit Kumar <[email protected]>
Co-authored-by: Fabian Braun <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1384 +/- ##
==========================================
+ Coverage 73.64% 73.98% +0.33%
==========================================
Files 75 75
Lines 3426 3436 +10
Branches 551 552 +1
==========================================
+ Hits 2523 2542 +19
+ Misses 732 722 -10
- Partials 171 172 +1
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
fsbraun
approved these changes
Jul 11, 2023
|
@vinitkumar I added tests. Please go check them and merge if you're ok! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thumbnail generation can fail when the image is not present or moved or if we have a reference in database but no image in storage.
Authored-by: Vinit Kumar [email protected]
Description
Related resources
Checklist
masterSlack to find a “pr review buddy” who is going to review my pull request.