docs(system-log): bootstrap docs/system-log/ and record 2026-07-17 session - #98
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9035e1dd71
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - Built `plugins/crm/` — a Dex-inspired personal CRM plugin (contacts, keep-in-touch cadences, interaction timeline, due-board, birthdays, cron-ready daily digest), modeled on the existing `plugins/teams_pipeline/` architecture. Hardened after a fan-out audit: `MAX_CADENCE_DAYS` overflow cap, month-aware calendar-date validation, fail-loud `CrmStoreError` on corrupt store files (previously silently returned empty data, risking clobber on next write), fixed a tag-leak bug in `render_digest`, corrected `docs/crm-pipeline.md`'s cron wiring example (shell substitution evaluated the digest once at cron-creation time instead of regenerating per fire). | ||
| - Fixed `hermes_cli/main.py`'s top-level dispatch: `args.func(args)`'s return value was discarded, so subcommands returning non-zero for real errors (1 = user error, 2 = usage error) still exited the process with 0, silently breaking scripted/cron callers checking `$?`. Verified safe via a subagent trace of all ~49 `set_defaults(func=...)` registrations. | ||
| - Bootstrapped this `docs/system-log/` directory per the account-wide documentation-duty convention (previously absent from this repo). | ||
| - **Commits/PRs:** `1085b297` (#94), `4bb288b8` (#95), `b763b0fe` (#96) — all squash-merged to `main`. |
There was a problem hiding this comment.
This audit entry lists only #94–#96, but repository history shows that plugins/crm/ was introduced by 47b7385 (#88), while #95 only hardened the existing plugin; similarly, the _PLATFORMS picker entries described above were restored by 5954d60 (#89), not #94. Include #88 and #89 here, or narrow the preceding summaries, so readers can trace every claimed change to the correct commit.
Useful? React with 👍 / 👎.
2 participants
Summary
docs/system-log/directory despite the account-wide documentation-duty convention (every repo maintains one, perdizhaky/.github's canonical spec).README.md(copied verbatim from the convention used acrossobsidian-vault,dotfiles,mcp-servers,crm-pipeline).2026-07-17.md, retroactively recording the three PRs merged earlier this session: fix(gateway): restore bespoke telegram/slack/matrix setup dispatch #94 (gateway setup-wizard fix), fix(crm): harden validation, fix tag-leak in digest, correct cron docs #95 (CRM plugin), fix(cli): propagate subcommand exit codes from the top-level dispatch #96 (CLI exit-code propagation).Test plan
docs/system-log/did not previously exist in this repo (git log/Glob— no prior history).git logfor the three referenced PRs.Generated by Claude Code