Skip to content

fix(memgw): catch ValueError on malformed URL in is_available (Codex PR#31 review) #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dizhaky merged 1 commit into from
Jun 26, 2026
Merged

fix(memgw): catch ValueError on malformed URL in is_available (Codex PR#31 review) #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion plugins/memory/memgw/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,12 @@ def is_available(self) -> bool:
# (Codex PR #30 review). Parse the URL and require an exact loopback host.
from urllib.parse import urlparse

host = (urlparse(url).hostname or '').lower()
try:
host = (urlparse(url).hostname or '').lower()
except ValueError:
# Malformed URL (e.g. typoed IPv6 like "http://[::1:8081/mcp") —
# treat as unavailable rather than propagating the exception.
return False
return host in ('localhost', '127.0.0.1', '::1')

def get_config_schema(self):
Expand Down
Loading