ci: add the two repaired tests to the Windows lane - #178
Merged
Conversation
Held back from #177 deliberately — over-including files caused both earlier rounds on this lane, so the fix landed first and the widening comes now that both files are cross-platform on main. Four files to six. The check I owe, since these are whole files (16 and 22 tests) rather than just the two assertions repaired in #177: in the first full-suite Windows run, job 93652696640, the only failures from these two files were update-relaunch.test.ts:54 and windows-hermes-path.test.ts:177. Every other test in them was observed passing on a Windows runner. The ssh-connection failures from that run are in a file that stays excluded. One gap observation could not cover: vitest stops at the first failing assertion in a test, so the second assertion of the test at :53 was never reached on Windows. The win32 simulation covers it explicitly and it passes after the repair — 14 passed, 0 failed across posix and win32. Selection re-verified: six of the project's 80 test files, with before-pack, stage-native-deps and ssh-connection still excluded. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012689txgT12g2hjRczcUZi8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The one-line follow-up I deliberately held back from #177. Both files are cross-platform and on
mainnow, so the lane can actually run them. Four files → six.The check I owe
These are whole files — 16 and 22 tests — not just the two assertions repaired in #177. Over-including files is what caused both earlier rounds on this lane (#174, #175), so the standard is observed evidence, not reasoning.
From the first full-suite Windows run (job
93652696640), the complete failure list was:So every other test in these two files was observed passing on a Windows runner. Nothing here rests on my judgement about what "should" work.
The one gap observation couldn't cover
vitest stops at the first failing assertion within a test, so the second assertion of the test at
:53was never reached on Windows. The win32 simulation covers it explicitly as "unpacked itself":Selection
Re-verified: six of the project's 80 test files, with
before-pack,stage-native-depsandssh-connectionstill excluded.The lane is a required check as of #176, so if either file has a Windows problem I haven't found, this PR is where it surfaces rather than on someone else's later change.
Follow-ups, unchanged
electron-buildercan't be imported under vitest on Windows (likely upstream).Generated by Claude Code