fix: display exception category, not raw text, in op SDK install paths - #132
Merged
Merged
Conversation
Two `cmd_op_setup`/`cmd_op_install` exception handlers still printed str(exc) from install_onepassword_sdk() failures — the last two sites in this module not already converted to type(exc).__name__, matching every other exception display here.
🔎 Lint report:
|
dizhaky
marked this pull request as ready for review
August 1, 2026 20:52
dizhaky
pushed a commit
that referenced
this pull request
Aug 1, 2026
…ening with merged #127/#130/#132 Conflict resolutions: - agent/secret_sources/onepassword.py (add/add): took main's version — it is the branch's file plus two hardening hunks that route tainted field labels/env names into the warnings list (surfaced only as counts) instead of logger.warning. - hermes_cli/secrets_cli.py: took main's side of both hunks — exception category display (type(exc).__name__) instead of str(exc). - .claude/settings.json: kept branch's newer server-memory pin (0.6.3). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014quAJiFx19py9nV6NnsnHr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Follow-up to #130. CodeQL's clear-text-logging check reported "2 new alerts including 2 high severity" on #130's fix commit (08dc27c), after that PR had already merged. This closes the gap: the last two
except Exception as exc:handlers inhermes_cli/secrets_cli.pystill printedstr(exc)directly.Related Issue
Follow-up to #130.
Type of Change
Changes Made
hermes_cli/secrets_cli.py:cmd_op_setupStep 1 (install_onepassword_sdk()failure):{exc}→{type(exc).__name__}cmd_op_install: same conversionBoth are now consistent with every other exception display in this module — a bare exception-class name, never the message text, matching the "Error categories" convention already established in
agent/secret_sources/onepassword.py.I audited every remaining
logger.warning/console.printcall acrossonepassword.py,env_loader.py, andsecrets_cli.pyfor this data-flow shape; these two were the only unconverted sites left.How to Test
Verification
ruff check hermes_cli/secrets_cli.py— clean.Generated by Claude Code