feat: allow_no_auth, for scenario where we could auth the client vi…

…a other parameters such as headers

feat: credentials can be fetch once the socket has been successfully upgraded to socks5 (hence successfully authenticated)

Cargo.toml

@@ -19,7 +19,7 @@ tokio = { version = "1.25.0", features = ["io-util", "net", "time", "macros"] }
 anyhow = "1.0"
 thiserror = "1.0"
 tokio-stream = "0.1.9"
-futures = "0.3"
+async-trait = "0.1.68"
 
 # Dependencies for examples and tests
 [dev-dependencies]

src/client.rs

@@ -1,6 +1,6 @@
 use crate::read_exact;
-use crate::util::target_addr::{read_address, TargetAddr, ToTargetAddr};
 use crate::util::stream::{tcp_connect, tcp_connect_with_timeout};
+use crate::util::target_addr::{read_address, TargetAddr, ToTargetAddr};
 use crate::{
     consts, new_udp_header, parse_udp_request, AuthenticationMethod, ReplyError, Result,
     Socks5Command, SocksError,
@@ -27,7 +27,10 @@ pub struct Config {
 
 impl Default for Config {
     fn default() -> Self {
-        Config { connect_timeout: None, skip_auth: false }
+        Config {
+            connect_timeout: None,
+            skip_auth: false,
+        }
     }
 }
 
@@ -185,7 +188,7 @@ where
             _ => {
                 debug!("Don't support this auth method, reply with (0xff)");
                 self.socket
-                    .write(&[
+                    .write_all(&[
                         consts::SOCKS5_VERSION,
                         consts::SOCKS5_AUTH_METHOD_NOT_ACCEPTABLE,
                     ])
@@ -209,7 +212,7 @@ where
             }) => Ok((username, password)),
             None => Err(SocksError::AuthenticationRejected(format!(
                 "Authentication rejected, missing user pass"
-            )))
+            ))),
         }?;
 
         let user_bytes = username.as_bytes();