Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Int parser for timeout and kerb arg support #186

Merged
merged 4 commits into from
Dec 8, 2017

Conversation

jborean93
Copy link
Collaborator

@jborean93 jborean93 commented Nov 28, 2017

Attempt to parse the *_timeout_sec variables and fail with a better error message

Will fix the following issues in Ansible without us manually handling it there.
ansible/ansible#33339
ansible/ansible#25539

Also set's a limit on the pytest version to 3.2.5 as 3.3.0 drops support for Python 2.6 and 3.3.

@coveralls
Copy link

coveralls commented Nov 29, 2017

Coverage Status

Coverage increased (+0.5%) to 72.349% when pulling edce459 on jborean93:parse-int into f2fae36 on diyan:master.

@coveralls
Copy link

coveralls commented Nov 29, 2017

Coverage Status

Coverage increased (+0.5%) to 72.349% when pulling 8e56a6e on jborean93:parse-int into f2fae36 on diyan:master.

@coveralls
Copy link

coveralls commented Nov 29, 2017

Coverage Status

Coverage increased (+0.5%) to 72.349% when pulling 591a4b6 on jborean93:parse-int into f2fae36 on diyan:master.

@jborean93 jborean93 changed the title Added handlers to parse timeout values from string Int parser for timeout and kerb arg support Dec 8, 2017
@coveralls
Copy link

coveralls commented Dec 8, 2017

Coverage Status

Coverage decreased (-0.4%) to 67.945% when pulling 9c308fd on jborean93:parse-int into 718f2b7 on diyan:master.

@coveralls
Copy link

coveralls commented Dec 8, 2017

Coverage Status

Coverage decreased (-1.8%) to 66.478% when pulling 2a97e03 on jborean93:parse-int into 718f2b7 on diyan:master.

@nitzmahone nitzmahone merged commit 1e88779 into diyan:master Dec 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants