-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ship 6 divviup-cli
binaries
#1088
Conversation
Builds `divviup-cli` for Windows, macOS and Linux, across x86_64 and aarch64. The resulting executables are attached to the release, as in https://github.com/divviup/divviup-api/releases/tag/0.3.7. Part of #492
There's some outstanding problems here:
We should do some research on this and maybe invest more effort in smoothing this out, but for now I want to get this action checked in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We now require that one of the features aws-lc-rs
or ring
be enabled. The former is enabled by default, so the upshot is that --no-default-features
won't work anymore. I changed the CI script accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My preference would be to automatically select feature ring
if the target is Windows and aws-lc-rs
otherwise, but you can't do that in cargo
yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a bummer the Windows runner images don't include NASM and Ninja, I assumed they would have.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
Any reason we wouldn't default to ring
in all cases?
Per discussion elsewhere, we have a preference for |
Builds
divviup-cli
for Windows, macOS and Linux, across x86_64 and aarch64. The resulting executables are attached to the release, as in https://github.com/divviup/divviup-api/releases/tag/0.3.7.Part of #492