Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship 6 divviup-cli binaries #1088

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Ship 6 divviup-cli binaries #1088

merged 2 commits into from
Jun 11, 2024

Conversation

tgeoghegan
Copy link
Contributor

Builds divviup-cli for Windows, macOS and Linux, across x86_64 and aarch64. The resulting executables are attached to the release, as in https://github.com/divviup/divviup-api/releases/tag/0.3.7.

Part of #492

Builds `divviup-cli` for Windows, macOS and Linux, across x86_64 and
aarch64. The resulting executables are attached to the release, as in
https://github.com/divviup/divviup-api/releases/tag/0.3.7.

Part of #492
@tgeoghegan tgeoghegan requested a review from a team as a code owner June 10, 2024 23:03
@tgeoghegan
Copy link
Contributor Author

There's some outstanding problems here:

  • Windows binaries get flagged as malware by Chrome and Edge when you download them
  • macOS binaries can't be run all that easily because they're not notarized or otherwise signed

We should do some research on this and maybe invest more effort in smoothing this out, but for now I want to get this action checked in.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We now require that one of the features aws-lc-rs or ring be enabled. The former is enabled by default, so the upshot is that --no-default-features won't work anymore. I changed the CI script accordingly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My preference would be to automatically select feature ring if the target is Windows and aws-lc-rs otherwise, but you can't do that in cargo yet.

Copy link
Collaborator

@divergentdave divergentdave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bummer the Windows runner images don't include NASM and Ninja, I assumed they would have.

Copy link
Contributor

@inahga inahga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

Any reason we wouldn't default to ring in all cases?

@tgeoghegan
Copy link
Contributor Author

Per discussion elsewhere, we have a preference for aws-lc-rs because it has more rigorous formal verification, more features and is backed by AWS' formidable cryptography engineering team. But I think ring is good enough for this Windows target.

@tgeoghegan tgeoghegan merged commit 904d010 into main Jun 11, 2024
7 checks passed
@tgeoghegan tgeoghegan deleted the timg/push-cli-artifact branch June 11, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants