Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include typescript source in npm package #8

Merged
merged 2 commits into from
Mar 29, 2020
Merged

Include typescript source in npm package #8

merged 2 commits into from
Mar 29, 2020

Conversation

jonaskello
Copy link
Member

This PR will include the typescript sources in src/ in the published npm package. We were already including *.map files but when eg. webpack tried to load them the referenced typescript files in src/ were not found so webpack emits a warning.

The choice is either to make a special production build without source maps and publish the *.js files without any sourcemap refrences, or include everything in the npm package. My reasoning here is that if we include everything it will be easier to get god stack traces and debug.

@codecov
Copy link

codecov bot commented Mar 29, 2020

Codecov Report

Merging #8 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #8   +/-   ##
=======================================
  Coverage   99.35%   99.35%           
=======================================
  Files         142      142           
  Lines         934      934           
  Branches        1        1           
=======================================
  Hits          928      928           
  Misses          5        5           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d217afb...7f259e9. Read the comment docs.

@jonaskello jonaskello merged commit 8c592f6 into master Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant