Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two sockets #1

Merged
merged 17 commits into from
Mar 28, 2023
Merged

Two sockets #1

merged 17 commits into from
Mar 28, 2023

Conversation

ackintosh
Copy link

@ackintosh ackintosh commented Mar 11, 2023 •
edited
Loading

sigp#160

Breaking changes

  • Discv5::new() now takes a ListenConfig parameter for the sockets to listen on.
  • Removed the listen_socket parameter from Discv5::start().
  • Discv5ConfigBuilder::ip_mode() has been removed. IpMode would be determined internally according to the ListenConfig parameter passed to Discv5::new().

Changes in examples

  • find_nodes
    • Added --port6

@ackintosh ackintosh changed the title [WIP] Two sockets Two sockets Mar 21, 2023
@ackintosh ackintosh marked this pull request as ready for review March 21, 2023 22:15
@divagant-martian divagant-martian merged commit e418016 into divagant-martian:two-sockets Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ackintosh @divagant-martian