-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addtional Map with New Content #424
base: main
Are you sure you want to change the base?
Conversation
To be clear, making changes to the existing map will likely break existing runs (which is checked by automated tests) and probably requires a new major version. The gravity flipping section is kinda fair game though, as changes to secrets are "allowed' without considered breaking (see https://github.com/divVerent/aaaaxy/blob/main/RELEASING.md#versioning). Some changes will need the checkpoint map to be recomputed, which technically breaks runs, but I assume time spent in the UI is minimal, so I would think that is OK in a minor version update as well. However, once the changes are significant enough, I will do the work to allow this to be an additional, "experimental" map to choose from in the game. |
From my understanding, if I change the existing map, I will need a major version as it may break speedruns. So should I really be changing the existing map? My goal simply was to add more to the existing map without changing the already created map. But this may have an impact on 100% speedruns. Therefore, I think that creating another map in the same Any suggestion in my approach? Edit: My english :p |
I'd prefer it being a separate level.tmx file, so these can later also be packed independently. I will add a selector UI for that. Thank you! |
Alright I will change the "Extend gravity flipping section" as "Add more gravity flipping section as a secret level". I will name the new file as I will be committing to the repo whenever I think that good, small but well defined progress has been made. I will definitely clarify any doubts and take any advice. It may take a long time for me to make a commit as Github is my hobby and not my full time. Thanks! |
QUERY 1Instead of going to the new map through UI, should we try to integrate it directly into the existing map as a secret? Like the screenshot below (sorry, should have written "To New Map", instead of "Addon Content"). Checkpoint - In The Beginning Of course this will no way affect the original map runs and players can switch between maps after this map has been discovered. But we need a way to find how to combine A consequence of this will be that any activated power ups from original map will remain in the new map and players will treat it like a optional extension of the original map. Not much of a concern but if you might want a completely different map with completely different progression then doing like this may not be the idea. So what should be the decision, start new map through UI or a secret path in original map? I am asking to help me make the starting section of the new map accordingly. |
Helps with #424 by allowing an alternate level tmx file by `-cheat_level=foo`.
I find this interesting, however I definitely don't think they can be connected seamlessly in the current design of the game logic. For now I'd suggest you consider them separate files, and I think I should find time later to add a command line flag to load a different .tmx file as a start for this. In the end, though, I can totally imagine using e.g. a "teleporter" added to the main map to jump to addon content, instead of a menu. There are definitely a few places where this could be safely added. |
Alright thanks! For now I will continue making the |
Problem 1When running Log:
I will anyway look for a solution for this. But it is recommended that you make a commit in your repo to fix this permanently. |
Side-note - Ignore this, unrelatedI have accidentally hidden my comments without knowing that these cannot be viewed without being signed in to Github. If the maintainer can unhide my comments then I request to do so as I cannot do it myself. I will no longer hide comments in future. Well now I am able to unhide for some reason |
I figured this out: you need to compile the game using:
This is seldomly needed, and disabled by default as the checkpoint locations depend on the exact version of the |
After inspecting the build scripts and Makefile, I can not believe that I was wasting time troubleshooting when the real problem was that in line 28
- if [ x"$AAAAXY_GENERATE_CHECKPOINT_LOCAITONS" = x'true' ]; then
+ if [ x"$AAAAXY_GENERATE_CHECKPOINT_LOCATIONS" = x'true' ]; then Further I had to change line 37 to take line 37
- neato -Tjson assets/generated/level.cp.dot > assets/generated/level.cp.json
+ neato -Tjson assets/generated/$lname.cp.dot > assets/generated/$lname.cp.json So Now I am able to play whatever I create in level2. I suggest making a commit in your repo to fix this. |
Sounds good so far! As you are working on a new map, I am considering implementing a new engine feature: slopes. Interested? |
Yep! I think it would be a cool feature. I will mention #428 here. Sorry for late response, been busy. |
Just a note here, I changed my username and my gpg sign key to be more public. Formerly known as HashingPath |
Sounds good! I now have played the game through after my code changes for slopes - I will soon release a version with that feature set, which will then also allow you to use the feature. |
Very cool! Look forward to it |
Filed #436 for the work to support multiple "worlds". |
Query 2Should I start a new discussion in this repository? I have some questions regarding the progression of the new map and some new features if possible. So I would like to start a discussion rather than discussing all here. |
Sounds good, feel free to start a discussion under "Discussions" - makes more sense there than on this PR anyway. |
I will create a discussion soon. |
As discussed in #423, this is a pull request for discussion of content which should be added. Any suggestion is appreciated. Below is a list of suggestion I think should be added. This may expand or change.
A new map is created for this -
assets/maps/level2.tmx
. Original map will remain same and additional content will be created inlevel2.tmx
.Current Roadmap
How to Test
Copy this fork repo and follow build instructions:
Now before running the
./aaaaxy
you need to runmake assets-update-all
mainly to generate the checkpoints map of all*.tmx
maps as it is required by the game.Tip: This is a long process so if you want, you can execute
sh scripts/generate-checkpoints-only.sh
(created only for this fork repo) to only generate the checkpoints map if its changed. But it is recommended to runmake assets-update-all
atleast once. This will be script will be removed once this repo becomes available for merging.To test the map, type
./aaaaxy -cheat_level <tmx>
where<tmx>
is replaced with the name of level file you want without the.tmx
extension. Level file must be located inassets/maps/*.tmx
to be used.This new map is written in level2, so run
./aaaaxy -cheat_level level2
to test. Remember! There is no save game when testing, you need to manually move your Player object in the Tiled application, save and then run to test different areas.