add function to create web3 instance from injected web3 #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinklepsch
commented
Mar 26, 2018
| (defn web3 | ||
| "Return the web3 instance injected via Mist or Metamask" | ||
| [] | ||
| (new (goog.object/getValueByKeys js/window "web3" "constructor") |
There was a problem hiding this comment.
used constructor access here as I felt it's a little more explicit
There was a problem hiding this comment.
I get nil when I call (web3/web3) but I get the proper instance when calling:
(new js/web3.constructor (web3-core/current-provider (goog.object/get js/window "web3")))
Do you have an idea why this could happen?
(I'm in a setup where MetaMask is unlocked etc.)
martinklepsch
commented
Mar 26, 2018
| ;; Create web3 instance from injected web3 (Mist / Metamask) | ||
| (web3/web3) | ||
|
|
||
| ;; Create web3 instance from HTTP provider | ||
| (web3/create-web3 "http://localhost:8545/") |
There was a problem hiding this comment.
Think it would be nice if this actually had http in the name somehow but it's part of the API now so I don't know 🙂
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #7