Updated readme to include --suboption, and changed all the options to use the proper double-dash. #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've added a fix to two aspects of the quota_health check: First of all, the user quotas would be essentially ignored, so I added code to handle that case. Second, the elsif in the quota checking meant that if there was a hard quota set, the soft quota or space-threshold would not be checked at all. |
… use the proper double-dash, rather than the special em-dash character.
… hard limit that was set would cause it to skip the check for the soft limit
|
Ok, after some trial and error I think I got the rebase right. |
|
@TexasDex Sry it took so long. Just tested it on our NetApp and seems to work fine. If you let me know your full name, I can add it to the list of contributors. Tx |
Open
|
Thanks! Feel free to credit me as Gordon Dexter
…On Wed, Apr 14, 2021 at 3:28 AM willemdh ***@***.***> wrote:
@TexasDex <https://github.com/TexasDex> Sry it took so long. Just tested
it on our NetApp and seems to work fine. If you let me know your full name,
I can add it to the list of contributors. Tx
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#91 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA5NF6QCWLQ6FHWB6RDY6ZLTIU7Y5ANCNFSM4STSVIWQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The --suboption argument wasn't listed in the readme.
Also, using em-dash for the long options doesn't work, and might cause problems if people copy/paste from documentation. Fixed by changing to double dash.