Enhancments in existing checks needed for more sophisticated setups and Bufixes (Replaces #88) #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
@Elias481 Sry it took so long. Just tested this on our Netapp and it seems to work fine. |
|
@Elias481 If you give me your full name, I'm ok with adding your name to the contributors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sadly I made a merge error and closed PR #88 while resetting my master ro upstream (and again even in this try the main error to work on master branch in fork...).
So here are the rebased changes.
For now I excluded the topic that overlaps some way with #89 , I have to copare both changes and see how far they overlap and how to implement the stuff that is most probably missing in #89 if it addreeses same thing or how to integrate my adjustments on top of #89.