Skip to content

Fixing issue with classes that don't gen breaking generator #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 2, 2025
Merged

Fixing issue with classes that don't gen breaking generator #290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion AutoCtor.sln
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution
src\nugetfiles\AutoCtor.badcompat.targets = src\nugetfiles\AutoCtor.badcompat.targets
src\nugetfiles\AutoCtor.props = src\nugetfiles\AutoCtor.props
src\nugetfiles\AutoCtor.targets = src\nugetfiles\AutoCtor.targets
.github\workflows\build.yml = .github\workflows\build.yml
src\Common.props = src\Common.props
src\Directory.Build.props = src\Directory.Build.props
src\Directory.Packages.props = src\Directory.Packages.props
Expand All @@ -30,6 +29,12 @@ Project("{D954291E-2A0B-460D-934E-DC6B0785DB48}") = "AutoCtor.Shared", "src\Auto
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "AutoCtor.Roslyn4.0", "src\AutoCtor.Roslyn4.0\AutoCtor.Roslyn4.0.csproj", "{F73002A3-779E-445D-B563-85361FD8B35F}"
EndProject
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "workflows", "workflows", "{02EA681E-C7D8-13C7-8484-4AC65E1B71E8}"
ProjectSection(SolutionItems) = preProject
.github\workflows\build.yml = .github\workflows\build.yml
.github\workflows\publish.yml = .github\workflows\publish.yml
EndProjectSection
EndProject
Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Debug|Any CPU = Debug|Any CPU
Expand Down Expand Up @@ -64,6 +69,9 @@ Global
GlobalSection(SolutionProperties) = preSolution
HideSolutionNode = FALSE
EndGlobalSection
GlobalSection(NestedProjects) = preSolution
{02EA681E-C7D8-13C7-8484-4AC65E1B71E8} = {8CC56491-C17C-44A5-8686-C41491E2E624}
EndGlobalSection
GlobalSection(ExtensibilityGlobals) = postSolution
SolutionGuid = {6C1E6B0F-E4E8-410D-A9C6-D9128CAC4EC8}
EndGlobalSection
Expand Down
2 changes: 1 addition & 1 deletion src/AutoCtor.Shared/AutoConstructSourceGenerator/Emitter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ public static void GenerateSource(
var (source, parameters) = GenerateSource(context, type, postCtorMethods, baseParameters, input.Guards);

if (source == null || parameters == null)
return;
continue;

ctorMaps.Add(type.TypeKey, parameters);

Expand Down
12 changes: 12 additions & 0 deletions src/AutoCtor.Tests/Examples/Broken251Release.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
public interface IService { }

[AutoCtor.AutoConstruct]
public partial class OtherClass
{
}

[AutoCtor.AutoConstruct]
public partial class Broken251Release
{
private readonly IService _service;
}
16 changes: 16 additions & 0 deletions ...s/Examples/Verified/Broken251Release.ExamplesGeneratedCode#Broken251Release.g.verified.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
//HintName: Broken251Release.g.cs
//------------------------------------------------------------------------------
// <auto-generated>
// This code was generated by https://github.com/distantcam/AutoCtor
// </auto-generated>
//------------------------------------------------------------------------------

partial class Broken251Release
{
[global::System.Runtime.CompilerServices.CompilerGeneratedAttribute]
[global::System.Diagnostics.DebuggerNonUserCodeAttribute]
public Broken251Release(global::IService service)
{
this._service = service;
}
}